fix(Avatar): add fallback workaround to graphemer import class #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ahuth
reviewed
Sep 7, 2023
| const splitter = new Graphemer(); | ||
| // @see https://github.com/flmnt/graphemer/issues/11 | ||
| // @ts-expect-error handles case where this library adds .default to the export inappropriately in CJS context | ||
| const G = Graphemer['default'] ? Graphemer.default : Graphemer; |
There was a problem hiding this comment.
Nit: might be able to use in and avoid the TS error
Suggested change
| const G = Graphemer['default'] ? Graphemer.default : Graphemer; | |
| const G = 'default' in Graphemer ? Graphemer.default : Graphemer; |
Although I can't imagine any of this makes TS happy 😆
There was a problem hiding this comment.
TypeScript HATES this one simple trick
😅
ahuth
approved these changes
Sep 7, 2023
booc0mtaco
added
the
do not merge
|
We don't need this workaround anymore, as setting cc @ahuth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Related to flmnt/graphemer#11, we have an issue in some consumers where the commonJS module is imported in such a way that we get the wrong object format. (instead of
[Graphemer class]we get{default: [Graphemer class]}, which causes the code to fail).Check for double-
defaultwrapping as a workaround until graphemer is fixed. This will also unblock work on the theming toolingTest Plan: